-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codepipeline): Add CodeConnections
source for creating codepipeline
#31028
feat(codepipeline): Add CodeConnections
source for creating codepipeline
#31028
Conversation
…econnection-source-to-codepipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
…source-to-codepipeline feat: add tests suits to review, for codepipeline-actions-source
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Creating a duplicate just because of the name change is not something that we want to do here. We can update the doc string and README to clarify that the name has been changed. |
@TheRealAmazonKendra thanks a lot for the review! I agree, I also don't like the way it is right now, but based on the issue, my understanding was to add a new source option, which in our case happens to be quite similar to the existing one. Could you please confirm if the intention was to simply update the documentation and README? I can proceed accordingly based on your suggestions. Thanks again :) |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue
Closes #30957
Reason for this change
This change allows the users to create the codepipeline using
CodeConnections
as a source.Description of changes
This involves addition of a new source option in the
codepipeline-source
and addition of a new actionCodeConnectionsSourceAction
for triggering the creation.Description of how you validated changes
🚧 WIP
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license